Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-specs] new test case for continuationtoken paging #6038

Merged
merged 15 commits into from
Feb 21, 2025

Conversation

msyyc
Copy link
Contributor

@msyyc msyyc commented Feb 18, 2025

fix #6060

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:http-specs For issues/prs related to the @typespec/http-specs package label Feb 18, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 18, 2025

All changed packages have been documented.

  • @typespec/http-specs
Show changes

@typespec/http-specs - feature ✏️

Add test case for continuationtoken paging

@azure-sdk
Copy link
Collaborator

azure-sdk commented Feb 18, 2025

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs 🛝 VSCode Extension

@msyyc msyyc changed the title [http-specs] new test case for continuationtoken [http-specs] new test case for continuationtoken paging Feb 18, 2025
Copy link
Contributor

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run a simple e2e test on Java prototype and it appears to be working.

My only remaining item is the name. Let's see whether there is another opinion on that.
(But at least resp instead of res?)

@msyyc msyyc requested a review from JoshLove-msft February 20, 2025 02:39
@msyyc
Copy link
Contributor Author

msyyc commented Feb 20, 2025

I've run a simple e2e test on Java prototype and it appears to be working.

My only remaining item is the name. Let's see whether there is another opinion on that. (But at least resp instead of res?)

Updated operation name with full name for request and response.

@msyyc msyyc enabled auto-merge February 20, 2025 06:16
@msyyc msyyc added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 0adfd9d Feb 21, 2025
24 checks passed
@msyyc msyyc deleted the http-specs-continucationtoken branch February 21, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib:http-specs For issues/prs related to the @typespec/http-specs package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paging ContinuationToken Scenario tests
7 participants