Pass tracer to SourceLoader to fix tracing
#5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SourceLoader` emits traces under the `"import-resolution"` namespace. During the refactor in d2ac995, we stopped passing the `tracer` to the `SourceLoader` so those traces weren't happening. This appear to be a bug, as `LoadSourceOptions` has a field for `tracer`.
steverice
requested review from
bterlson,
markcowl,
allenjzhang,
timotheeguerin and
witemple-msft
as code owners
timotheeguerin
approved these changes
Feb 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@timotheeguerin I think that #5837 should fix the failing build 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SourceLoaderemits traces under the"import-resolution"namespace.During the refactor in d2ac995, we stopped passing the
tracerto theSourceLoaderso those traces weren't happening.This appear to be a bug, as
LoadSourceOptionshas a field fortracer.