tsp, dpg, keep enum type for client parameters, not change it to string type

[haolingdong-msft]

Fix Azure/autorest.java#2974
related with https://gist.github.com/haolingdong-msft/df3f25a048baf83d8fabf5206aacc7db#8-clienttype-will-be-generated-after-adopting-tcgc

Existing code

We change enum type to string type in two classes:

1. ProxyParameterMapper:

   typespec/packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/ProxyParameterMapper.java

   Lines 69 to 71 in 08384aa

   	if (settings.isDataPlaneClient()) {
   	clientType = SchemaUtil.removeModelFromParameter(parameterRequestLocation, clientType);
   	}

2. ServiceClientMapper:

   typespec/packages/http-client-java/generator/http-client-generator-core/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/ServiceClientMapper.java

   Lines 235 to 239 in 08384aa

   	if (settings.isDataPlaneClient()) {
   	// mostly for Enum to String
   	serviceClientPropertyClientType = SchemaUtil.removeModelFromParameter(RequestParameterLocation.URI,
   	serviceClientPropertyClientType);
   	}

Logic in this pr

Above classes calls SchemaUtil.removeModelFromParameter to remove enum type and change it to string type.
Currently I modify the logic in removeModelFromParameter() to not chang enum type to string type for dataplane path/uri parameters.

Would like to hear your thoughts on below: @weidongxu-microsoft @XiaofeiCao

1. The logics can also be put in each Mapper, currently I centralized the logics to SchemaUtil class.
2. We may also need to add a flag to control this because it will impact existing libraries. The flag can be named as path-parameter-enum-as-string.

---

Latest logics

After discussing with Weidong, we aggreed to put the logics into the mappers and keep the type in protocol method be enum as well.

1. Define a protected function protected boolean isRemoveModelFromParameter(Parameter parameter, IType type) in both ProxyParameterMapper and ServiceClientMapper.
2. Override the function in the subclass extends above mappers. In the override function, the logic will be not remove model from parameter if the type is enum and parameter location is client.

[azure-sdk]

No changes needing a change description found.

[azure-sdk]

You can try these changes here

🛝 Playground	🌐 Website	📚 Next docs