Improvements to type relation errors #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
compiler:core
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
…heeguerin/typespec into type-relation-improvements
timotheeguerin
requested review from
bterlson,
markcowl and
allenjzhang
as code owners
chrisradek
approved these changes
Sep 6, 2024
sarangan12
pushed a commit
to sarangan12/typespec
that referenced
this pull request
Sep 16, 2024
fix microsoft#3291 Changes: 1. Figure out the most accurate location for the diagnostic 2. If diagnostic target a child node of the base diagnostic target then emit diagnostic directly there 3. Otherwise emit back at the root(or closest child node) and build stack of error message Example the following would now emit the error on a ```ts const b = #{ prop: #{a: "abc"}}; const a: {prop: {}} = b; ``` ``` Type '{ prop: { a: "abc" } }' is not assignable to type '{ prop: {} }' Type '{ a: "abc" }' is not assignable to type '{}' Object value may only specify known properties, and 'a' does not exist in type '{}'. ``` Previously the error would have been in the complete wrong place <img width="271" alt="image" src="https://github.com/user-attachments/assets/c403d1ec-3611-4ad6-87b0-2e0a075dc1c5">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3291
Changes:
Example the following would now emit the error on a
Previously the error would have been in the complete wrong place
