Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out how to share the common logic of building constructor parameters between assemblies #3871

Closed
ArcturusZhang opened this issue Jul 17, 2024 · 0 comments · Fixed by #4143
Closed

Figure out how to share the common logic of building constructor parameters between assemblies #3871

ArcturusZhang opened this issue Jul 17, 2024 · 0 comments · Fixed by #4143
Assignees
@jorgerangel-msft
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@ArcturusZhang
Copy link
Member

#3730 (comment)
In ModelProvider we have a method to construct the parameters for its constructor, and we have similar things in MrwSerializationTypeDefinition as well, we need to find a way to share those in a common place.

typespec/packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/ModelProvider.cs

Line 113 in de74992

{

typespec/packages/http-client-csharp/generator/Microsoft.Generator.CSharp.ClientModel/src/Providers/MrwSerializationTypeDefinition.cs

Line 1021 in de74992

private (IReadOnlyList<ParameterProvider> Parameters, ConstructorInitializer? Initializer) BuildSerializationConstructorParameters()

@ArcturusZhang ArcturusZhang mentioned this issue Jul 17, 2024
Merged
@timotheeguerin timotheeguerin added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Jul 17, 2024
@jorgerangel-msft jorgerangel-msft self-assigned this Aug 8, 2024
@m-nash m-nash mentioned this issue Aug 8, 2024
Merged
@jorgerangel-msft jorgerangel-msft mentioned this issue Aug 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 12, 2024
@jorgerangel-msft
Move model serialization ctor to model provider (#4143)
1e3ccc2 
fixes: #3871
sarangan12 pushed a commit to sarangan12/typespec that referenced this issue Sep 16, 2024
@jorgerangel-msft @sarangan12
Move model serialization ctor to model provider (microsoft#4143)
9937e57 
fixes: microsoft#3871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgerangel-msft jorgerangel-msft

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move model serialization ctor to model provider jorgerangel-msft/typespec
3 participants
@timotheeguerin @ArcturusZhang @jorgerangel-msft