Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Unable to override HTTP method from operation template #3636

Closed
4 tasks done
johanste opened this issue Jun 20, 2024 · 1 comment · Fixed by #3717
Closed
4 tasks done

[Bug]: Unable to override HTTP method from operation template #3636

johanste opened this issue Jun 20, 2024 · 1 comment · Fixed by #3717
Assignees
@timotheeguerin
Labels
design:needed A design request has been raised that needs a proposal feature New feature or request lib:http triaged:core
Milestone
[2024] August

Comments

@johanste
Copy link
Contributor

Describe the bug

If I have an operation template that has a default http method (e.g. GET) but I want to override it in the actual instantiation, the typespec/http library will error. Since it is an error, I can't suppress it.

We should instead a) emit a warning and b) let the "outermost" application "win".

Reproduction

playground

Checklist
@johanste johanste added the bug Something isn't working label Jun 20, 2024
johanste added a commit to johanste/typespec that referenced this issue Jun 20, 2024
@johanste
Unable to override HTTP method from operation template - issue micros…
663455e 
…oft#3636
@johanste johanste mentioned this issue Jun 20, 2024
Closed
@markcowl markcowl added feature New feature or request design:needed A design request has been raised that needs a proposal and removed bug Something isn't working labels Jun 24, 2024
@markcowl markcowl added this to the [2024] August milestone Jun 24, 2024
@markcowl markcowl self-assigned this Jun 25, 2024
@markcowl
Copy link
Contributor

  • continue an error diagnostic for two different http verb decorators on the same node
  • otherwise, allow the outermost decorator to override

@timotheeguerin timotheeguerin mentioned this issue Jul 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 1, 2024
@timotheeguerin
Allow overriding base operation verb (#3717)
ce10ed9 
fix #3636

[Playground
example](https://cadlplayground.z22.web.core.windows.net/prs/3717/?c=aW1wb3J0ICJAdHlwZXNwZWMvaHR0cCI7Cgp1c2luZyBUeXBlU3BlYy5IdHRwOwpAc2VydmljZQpuYW1lc3BhY2UgRGVtb1PGFjsKCi8vIFRoaXMgc2hvdWxkIGJlIGFuIGVycm9yCkByb3V0ZSgiMSIpCkBnZXTGBW9wIG9wMSgpOiB2b2lk30LHQjLJQnBvc8dDMstDxBwgb3AgQmFzZTxUPsQaVMZaTm8gd2FybuQA2mhlcmXJUjQiKSDFTcQ3b3ZlcnJpZGUgaXPGQ3N0cmluZz47Cg%3D%3D&e=%40typespec%2Fopenapi3&options=%7B%22linterRuleSet%22%3A%7B%22extends%22%3A%5B%22%40typespec%2Fhttp%2Fall%22%5D%7D%7D)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
design:needed A design request has been raised that needs a proposal feature New feature or request lib:http triaged:core
Projects
None yet
Milestone
[2024] August
3 participants
@timotheeguerin @markcowl @johanste