Sort numeric symbols #690
Open
Sort numeric symbols #690
+594
−311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # testdata/baselines/reference/submodule/compiler/mappedTypeIndexedAccessConstraint.types # testdata/baselines/reference/submodule/compiler/mappedTypeIndexedAccessConstraint.types.diff # testdata/baselines/reference/submodule/compiler/objectLiteralIndexerErrors.types.diff # testdata/baselines/reference/submodule/compiler/objectLiteralIndexers.types.diff # testdata/baselines/reference/submodule/compiler/propertiesAndIndexers.types.diff # testdata/baselines/reference/submodule/conformance/objectTypeWithStringNamedNumericProperty.types.diff
ahejlsberg
reviewed
Mar 22, 2025
| @@ -628,6 +629,17 @@ func (c *Checker) compareSymbolsWorker(s1, s2 *ast.Symbol) int { | |||
| if s2 == nil { | |||
| return -1 | |||
| } | |||
| int1, err1 := strconv.Atoi(s1.Name) | |||
| int2, err2 := strconv.Atoi(s2.Name) | |||
There was a problem hiding this comment.
I'm afraid it's not that simple. Consider symbols named "0", "00", and "000" and so on! We'd want a check that the symbol round-trips as a number. Which unfortunately is a more expensive check.
There was a problem hiding this comment.
Good point, I can implement that - as long as it's even something you'd like to see getting in. At the moment, the main user-oriented improvement in this is a better error message here: testdata/baselines/reference/submodule/conformance/arityAndOrderCompatibility01.errors.txt. But at the same time, this test case isn't exercising a particularly popular pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jakebailey mentioned this is something the team is considering to do.