Skip most CI jobs when PR is unbuildable #435
Open
+16
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-32
to
+29
| - run: npx hereby build | ||
| - run: go test -c -o=/dev/null ./... |
There was a problem hiding this comment.
Do we still have something that actually tests hereby builds?
There was a problem hiding this comment.
No, but this is actually "stronger" since it checks tests. But it won't catch if the herebyfile breaks.
This PR still takes longer to build than I am expecting, probably due to the lack of build caching, so I'm not sure I even want to do this PR anymore.
karamaru-alpha
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves some resources when the PR doesn't build (which is especially helpful to not waste our custom runners).