Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Commit

Permalink
Enabled TS strict mode (#492)
Browse files Browse the repository at this point in the history
* Enabled TS strict mode

It felt right to upgrade TypeScript and TSLint to the latest versions for this.

Fixes #461

* Updated package-lock.json to latest; ran npm audit fix
  • Loading branch information
Josh Goldberg authored Aug 27, 2018
1 parent b592255 commit daacae9
Show file tree
Hide file tree
Showing 79 changed files with 636 additions and 466 deletions.
4 changes: 4 additions & 0 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -320,12 +320,15 @@ module.exports = function(grunt) {
'cyclomatic-complexity': true, // too strict
'deprecation': true, // requires type checking
'file-header': true, // no need
'file-name-casing': true, // too strict
'interface-name': true, // no need
'match-default-export-name': true, // requires type checking
'max-classes-per-file': true, // no need
'max-file-line-count': true, // no need
'member-ordering': true, // too strict
'newline-before-return': true, // kind of a silly rule
'newline-per-chained-call': true, // too strict
'no-dynamic-delete': true, // too strict
'no-empty-line-after-opening-brace': true, // too strict
'no-inferrable-types': true, // we prefer the opposite
'no-multiline-string': true, // too strict
Expand All @@ -339,6 +342,7 @@ module.exports = function(grunt) {
'prefer-conditional-expression': true, // not sure if this is needed
'prefer-switch': true, // no need
'prefer-template': true, // rule does not handle multi-line strings nicely
'prefer-while': true, // not sure if this is needed
'return-undefined': true, // requires type checking
'type-literal-delimiter': true, // not sure if this is needed
'typedef-whitespace': true, // too strict
Expand Down
40 changes: 40 additions & 0 deletions additional_rule_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@
"group": "Whitespace",
"commonWeaknessEnumeration": "710"
},
"file-name-casing": {
"issueClass": "Non-SDL",
"issueType": "Warning",
"severity": "Moderate",
"level": "Opportunity for Excellence",
"group": "Clarity",
"commonWeaknessEnumeration": "398, 710"
},
"forin": {
"issueClass": "Non-SDL",
"issueType": "Warning",
Expand Down Expand Up @@ -156,6 +164,14 @@
"group": "Clarity",
"commonWeaknessEnumeration": "710"
},
"newline-per-chained-call": {
"issueClass": "Non-SDL",
"issueType": "Warning",
"severity": "Moderate",
"level": "Opportunity for Excellence",
"group": "Clarity",
"commonWeaknessEnumeration": "398, 710"
},
"no-angle-bracket-type-assertion": {
"issueClass": "Ignored",
"issueType": "Warning",
Expand Down Expand Up @@ -254,6 +270,14 @@
"group": "Correctness",
"commonWeaknessEnumeration": "398"
},
"no-dynamic-delete": {
"issueClass": "Non-SDL",
"issueType": "Warning",
"severity": "Moderate",
"level": "Opportunity for Excellence",
"group": "Clarity",
"commonWeaknessEnumeration": "398, 710"
},
"no-empty": {
"issueClass": "Non-SDL",
"issueType": "Warning",
Expand Down Expand Up @@ -498,6 +522,22 @@
"group": "Clarity",
"commonWeaknessEnumeration": "398, 710"
},
"prefer-readonly": {
"issueClass": "Non-SDL",
"issueType": "Warning",
"severity": "Moderate",
"level": "Opportunity for Excellence",
"group": "Clarity",
"commonWeaknessEnumeration": "398, 710"
},
"prefer-while": {
"issueClass": "Non-SDL",
"issueType": "Warning",
"severity": "Moderate",
"level": "Opportunity for Excellence",
"group": "Clarity",
"commonWeaknessEnumeration": "398, 710"
},
"quotemark": {
"issueClass": "Non-SDL",
"issueType": "Warning",
Expand Down
Loading

0 comments on commit daacae9

Please sign in to comment.