Allow multilabels in VectorDataset #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
adamjstewart
approved these changes
Oct 24, 2022
|
@microsoft-github-policy-service agree company="Bain & Company" |
|
Thanks Adam! Just updated with your suggested changes and I accepted the CLA. |
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* add label_name param to VectorDataset * small fix by black * add tests * reuse CustomVectorDataset * versionadded in docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies VectorDataset to handle multiple labels. Without this, masks built from shapefiles are always coded into binary masks.
An optional parameter
label_nameis added to VectorDataset to indicate the name of the property where the label is stored in the shapefile. This label is then rasterized to the mask, instead of just a 1.Here is an example of a mask from a VectorDataset using this option:
I added an additional test to VectorDataset, but I'm not sure its the right way to do it. Let me know if it's ok or I can change it if needed.