Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InriaAerialImageLabeling dataset #355

Merged
merged 17 commits into from
Jan 13, 2022
Merged

Add InriaAerialImageLabeling dataset #355

merged 17 commits into from
Jan 13, 2022

Conversation

ashnair1
Copy link
Collaborator

@ashnair1 ashnair1 commented Jan 7, 2022 •
edited
Loading

  • Add the Inria Aerial Image Labeling dataset. The dataset consists of aerial RGB imagery and building masks.
  • Add tests and data.py to generate test data

Note: Images and masks are of size: 5000 x 5000

Plots
inria_bldgs

@github-actions github-actions bot added datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing labels Jan 7, 2022
@ashnair1 ashnair1 marked this pull request as ready for review January 7, 2022 18:48
isaaccorley
isaaccorley requested changes Jan 7, 2022
View reviewed changes
Copy link
Collaborator

@isaaccorley isaaccorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few suggested changes.

docs/api/datasets.rst Outdated Show resolved Hide resolved
tests/data/inria/data.py Outdated Show resolved Hide resolved
tests/datasets/test_inria.py Show resolved Hide resolved
torchgeo/datasets/inria.py Outdated Show resolved Hide resolved
torchgeo/datasets/inria.py Show resolved Hide resolved
torchgeo/datasets/inria.py Outdated Show resolved Hide resolved
torchgeo/datasets/inria.py Outdated Show resolved Hide resolved
torchgeo/datasets/inria.py Outdated Show resolved Hide resolved
torchgeo/datasets/inria.py Outdated Show resolved Hide resolved
torchgeo/datasets/inria.py Outdated Show resolved Hide resolved
@isaaccorley
Copy link
Collaborator

Thanks for adding this btw. I was planning on implementing it myself for a project but you beat me to it.

@adamjstewart adamjstewart added this to the 0.3.0 milestone Jan 8, 2022
@ashnair1 ashnair1 changed the title Add Inria Aerial Image Labeling dataset Add InriaAerialImageLabeling dataset Jan 8, 2022
adamjstewart
adamjstewart requested changes Jan 8, 2022
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your data.py file is quite different than the other ones in our repo. I'm not opposed to generating testing data on-the-fly so that we have fewer files in our repo, but I think it's something we should decide globally and not just for a single dataset.

docs/api/datasets.rst Outdated Show resolved Hide resolved
tests/data/inria/data.py Show resolved Hide resolved
tests/data/inria/data.py Outdated Show resolved Hide resolved
tests/data/inria/data.py Show resolved Hide resolved
tests/data/inria/data.py Show resolved Hide resolved
tests/datasets/test_inria.py Show resolved Hide resolved
torchgeo/datasets/inria.py Show resolved Hide resolved
torchgeo/datasets/inria.py Outdated Show resolved Hide resolved
torchgeo/datasets/inria.py Show resolved Hide resolved
torchgeo/datasets/inria.py Outdated Show resolved Hide resolved
adamjstewart
adamjstewart reviewed Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor changes and this is ready to go for me.

tests/datasets/test_inria.py Outdated Show resolved Hide resolved
torchgeo/datasets/inria.py Show resolved Hide resolved
torchgeo/datasets/inria.py Show resolved Hide resolved
@adamjstewart adamjstewart merged commit 08a365f into microsoft:main Jan 13, 2022
@ashnair1 ashnair1 deleted the inria branch January 13, 2022 18:42
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
Merged
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@ashnair1
Add InriaAerialImageLabeling dataset (microsoft#355)
3c56822 
* Add InriaBuildings dataset

* Add tests and test data

* Nit

* Add type-hints

* Image always 3 channel

* Increase coverage

* Update docstring

* Add more tests

* Remove np.typing

* Fix test lbl range

* Fixes

* Fix title underline

* Forgot to add this file

* Fixes2

* Fixes3

* Move download sentence

* toto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

@isaaccorley isaaccorley isaaccorley approved these changes

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ashnair1 @isaaccorley @adamjstewart