Adding OSCD dataset #233
Adding OSCD dataset #233
Conversation
|
|
There was a problem hiding this comment.
Hi @iejMac, thanks for the contribution!
Can you add docs for this dataset in docs/api/datasets.rst? Let me know if you have any questions about any of the remaining TODOs in the file.
There was a problem hiding this comment.
All of the style tests are failing. Most of these can be solved by simply running black . and isort ., but see https://torchgeo.readthedocs.io/en/latest/user/contributing.html#linters for a full set of instructions on this.
…ht be in the future
… but might be in the future" This reverts commit cfbf26c.
|
I've slimmed down the dummy test dataset to only files that are used to create a dataset of length 1. |
|
Yeah a separate PR should be fine. |
|
This looks good to me, just need to fix the mypy/pytest issues. |
| ), | ||
| } | ||
|
|
||
| md5 = "7383412da7ece1dca1c12dc92ac77f09" |
There was a problem hiding this comment.
This dataset downloads 3 different zip files but uses the same MD5 for all of them. This is a bug, right? Going to try to fix this in #329 since I need to regenerate the data anyway.
There was a problem hiding this comment.
What I'm really curious about is the fact that the tests still pass even with the wrong checksum. Even if I change the zip file entirely it still passes the tests.
adamjstewart
added
utilities
* OSCD: initial template * updating download pattern * package: including OSCD in torchgeo.datasets * download: adapting download method to OSCD dataset + adding simple test for debugging * _load_files method: temporary implementation * OCSD: minimum working example, needs plenty improvement * adding OSCD to docs * Moving test to appropriate location * OSCD: remove sort_bands and use utils.sort_sentinel2_bands * Using rasterio instead of tifffile * remove useless import * style changes * fix: style * Developing tests for OSCD dataset * Updating dataset description * change name * style fixes * fixing mypy errors * style fixes * cast to string to fix typing errors * style change * isort fix * remove TODO * adding dataset for testing * change len * check if sum is concatdataset * isort fix * fixing some issues + correct md5 in dataset * closing rasterio file handles * removing some TODO's * transitioning to fake data * mypy fix attempt * set fake data md5 * flake8 fix * starting plot method * updating plot method * no predictions for now * fixing style errors * add testing for plot * making some changes to fake testing data * full coverage * Use RGB channels in the plot function * adding shape tests in test_getitem * remove features and add to description * fixing some things * transitioning to authors dataset link * No need to change file names + adapt test dataset * adapting tests to new data format * Update docs/api/datasets.rst Co-authored-by: Adam J. Stewart <[email protected]> * closing plot at end of terst * add versionadded * style fixes + indentation fixes * style fixes * forgot the .zip * fix zipfile name * temporary fix for flake8 * Add link to docs * forgot to adjust this * changing flake8 solve * slimming down the test dataset * removing imgs_x files which aren't needed for current testing but might be in the future * Revert "removing imgs_x files which aren't needed for current testing but might be in the future" This reverts commit cfbf26c. * nevermind, this was the issue * trying to remove these once again * adding band choosing functionality * removing double code * removing more double code * flake8 fix * adding one more training sample to dummy dataset and testing split * typing numpy array * back to this * Fixing tests and mypy Co-authored-by: Caleb Robinson <[email protected]> Co-authored-by: Adam J. Stewart <[email protected]>
No description provided.