Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding South America Soybean Dataset #1668

Merged
merged 82 commits into from
Feb 6, 2024
Merged

Adding South America Soybean Dataset #1668

merged 82 commits into from
Feb 6, 2024

Conversation

cookie-kyu
Copy link
Contributor

Created file south_america_soybean.py for dataset and added its definition to init.py

@github-actions github-actions bot added the datasets Geospatial or benchmark datasets label Oct 16, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation testing Continuous integration testing labels Nov 8, 2023
yichiac
yichiac suggested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@yichiac yichiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename class name to follow PEP 8 style with CamelCase.

torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
yichiac
yichiac suggested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@yichiac yichiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix inconsistent test file path

tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
tests/datasets/test_south_america_soybean.py Outdated Show resolved Hide resolved
@adamjstewart adamjstewart added this to the 0.6.0 milestone Nov 16, 2023
yichiac
yichiac suggested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@yichiac yichiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix dataset plotting and remove redundant code. Still need to check test functions and styles.

torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
cookie-kyu and others added 16 commits November 17, 2023 19:48
@cookie-kyu @yichiac
Update torchgeo/datasets/south_america_soybean.py
fd01011 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update tests/datasets/test_south_america_soybean.py
46db62b 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update tests/datasets/test_south_america_soybean.py
f53d822 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update tests/datasets/test_south_america_soybean.py
1ed0c28 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update tests/datasets/test_south_america_soybean.py
7a8e0cf 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update tests/datasets/test_south_america_soybean.py
6b8b143 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update tests/datasets/test_south_america_soybean.py
38bc7cb 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update tests/datasets/test_south_america_soybean.py
95f5368 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update torchgeo/datasets/south_america_soybean.py
b6c9efc 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update torchgeo/datasets/south_america_soybean.py
5bf910b 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update torchgeo/datasets/south_america_soybean.py
2c2cc42 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update torchgeo/datasets/south_america_soybean.py
3eb2e33 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update torchgeo/datasets/south_america_soybean.py
355d8f1 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update torchgeo/datasets/south_america_soybean.py
430674a 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update torchgeo/datasets/south_america_soybean.py
5cc76e7 
Co-authored-by: Yi-Chia Chang <[email protected]>
@cookie-kyu @yichiac
Update torchgeo/datasets/south_america_soybean.py
6cc7e7c 
Co-authored-by: Yi-Chia Chang <[email protected]>
@adamjstewart
Copy link
Collaborator

Not sure why the CI tests aren't running...

It was because the branch was out of date with main and needed to be updated.

@adamjstewart
Copy link
Collaborator

Also need to accept the license, see the above instructions.

@cookie-kyu
Copy link
Contributor Author

@microsoft-github-policy-service agree

@cookie-kyu cookie-kyu marked this pull request as ready for review January 29, 2024 00:13
adamjstewart
adamjstewart requested changes Jan 29, 2024
View reviewed changes
docs/api/geo_datasets.csv Outdated Show resolved Hide resolved
tests/.DS_Store Outdated Show resolved Hide resolved
tests/data/south_america_soybean/data.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Show resolved Hide resolved
adamjstewart
adamjstewart requested changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor changes remaining, almost done

torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Outdated Show resolved Hide resolved
torchgeo/datasets/south_america_soybean.py Show resolved Hide resolved
@adamjstewart adamjstewart enabled auto-merge (squash) February 6, 2024 09:53
@adamjstewart adamjstewart disabled auto-merge February 6, 2024 12:11
@adamjstewart adamjstewart merged commit f5624ac into microsoft:main Feb 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yichiac yichiac yichiac requested changes

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cookie-kyu @adamjstewart @yichiac