README: update Lightning trainer examples #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
commented
Mar 30, 2023
| landsat7 = Landsat7(root="...") | ||
| landsat8 = Landsat8(root="...", bands=Landsat8.all_bands[1:-2]) | ||
| landsat7 = Landsat7(root="...", bands=["B1", ..., "B7"]) | ||
| landsat8 = Landsat8(root="...", bands=["B2", ..., "B8"]) |
There was a problem hiding this comment.
This is more clear how it works
adamjstewart
commented
Mar 30, 2023
| @@ -124,8 +125,18 @@ In order to facilitate direct comparisons between results published in the liter | |||
|
|
|||
| ```python | |||
| datamodule = InriaAerialImageLabelingDataModule(root="...", batch_size=64, num_workers=6) | |||
| task = SemanticSegmentationTask(segmentation_model="unet", encoder_weights="imagenet", learning_rate=0.1) | |||
There was a problem hiding this comment.
Parameter names changed. At the moment, every single argument is required, although I'm planning on changing this in the future.
adamjstewart
commented
Mar 30, 2023
| @@ -124,8 +125,18 @@ In order to facilitate direct comparisons between results published in the liter | |||
|
|
|||
| ```python | |||
| datamodule = InriaAerialImageLabelingDataModule(root="...", batch_size=64, num_workers=6) | |||
| task = SemanticSegmentationTask(segmentation_model="unet", encoder_weights="imagenet", learning_rate=0.1) | |||
| trainer = Trainer(gpus=1, default_root_dir="...") | |||
There was a problem hiding this comment.
gpus=1 is replaced by accelerator="gpu", devices=1, but the correct device is now chosen automatically by default.
isaaccorley
approved these changes
Mar 31, 2023
nilsleh
approved these changes
Mar 31, 2023
calebrob6
pushed a commit
that referenced
this pull request
Apr 10, 2023
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some things that were out of date.