Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weights: add sha256 suffix #1105

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Weights: add sha256 suffix #1105

merged 2 commits into from
Feb 20, 2023

Conversation

adamjstewart
Copy link
Collaborator

This PR includes the following changes:

  • Add the first 8 digits of the sha256 to the filename suffix
  • Standardize on .pth file extension
  • Sort weights alphabetically
  • Keep URLs on a single line

All old weights still exist at the same URLs for backwards compatibility. All new weights should follow this <name>-<sha256>.pth format.

References:

We won't actually be able to use this checksum until torchvision 0.15.0, but might as well do the heavy lifting now.

@adamjstewart adamjstewart added this to the 0.4.1 milestone Feb 11, 2023
@adamjstewart adamjstewart requested a review from nilsleh February 11, 2023 23:56
@github-actions github-actions bot added documentation Improvements or additions to documentation models Models and pretrained weights labels Feb 11, 2023
@adamjstewart adamjstewart marked this pull request as ready for review February 12, 2023 00:08
"model": "resnet50",
"publication": "https://arxiv.org/abs/2211.07044",
"repo": "https://github.com/zhu-xlab/SSL4EO-S12",
"ssl_method": "dino",
"ssl_method": "moco",
},
)

SENTINEL2_RGB_SECO = Weights(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have defined the zhu_lab_transforms, and I was looking into the Seco code again and at least for the bigearthnet datamodule on which they run experiments, augmentations are defined here. Do you want to add those?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Can you add it in a separate PR though? That can fix #1042.

@nilsleh nilsleh merged commit 89de965 into main Feb 20, 2023
@nilsleh nilsleh deleted the weights/sha256 branch February 20, 2023 18:19
calebrob6 pushed a commit that referenced this pull request Apr 10, 2023
* Weights: add sha256 suffix

* Fix URL
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
* Weights: add sha256 suffix

* Fix URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation models Models and pretrained weights
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants