-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ATS tab status indicators #9076
Conversation
Don-Vito
commented
Feb 8, 2021
•
edited
Loading
edited
- Fix progress value not updated
- Introduce TabStatus object and bind both TabHeaderControl and CommandPalette to it
- Add support for read-only mode indicator
@zadjii-msft - I missed the progress value in the original PR 😢 Instead of an interface I creates a TabStatus object and bind all controls to it. Marked as draft, as for some reason the ATS bindings are sometimes not updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea so far I'm cool with what's here.
@zadjii-msft - for some reasons nested bindings were not updating to me.. so I added a code in the TabPaletteItem that notifies changes on the entire status if one of the indicators changes. This should have no implications, but it is definitely annoying and feels like voodoo. |
@carlos-zamora - please take a look as well. There are some gaps I missed originally + I did something simpler to avoid properties duplication by now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg this is so much cleaner. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for hoping on this so quickly. What a fun bit of polish |
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |