Teach tab tool tips to show key bindings #8810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-UserInterface
DHowett
approved these changes
Jan 17, 2021
| SwitchToTabArgs args{ _TabViewIndex }; | ||
| ActionAndArgs switchToTab{ ShortcutAction::SwitchToTab, args }; | ||
| const auto keyChord = _keymap ? _keymap.GetKeyBindingForActionWithArgs(switchToTab) : nullptr; | ||
| const auto keyChordText = keyChord ? KeyChordSerialization::ToString(keyChord) : L""; |
There was a problem hiding this comment.
weird enough, I think we have another keychord->string converter too living in TerminalPage. Not sure which one we should use here. This one used to be used in settings re-serialization, so it was less user-facing.
The one in TerminalApp is admittedly strange. Probably best not to use it.
|
This is great! Thank you 😄 |
zadjii-msft
approved these changes
Jan 19, 2021
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
mpela81
pushed a commit
to mpela81/terminal
that referenced
this pull request
Jan 28, 2021
<!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes microsoft#2886 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments Currently the tab tool tip is the tab's title. The PR teaches the TabBase to check if there is a switch to tab command associated with the current tab index, if so concatenates the the relevant mapping to the too tip. Of course, prefers user defined bindings to the default ones. Moved tool tip logic to TabBase so SettingsTab has tooltip as well. 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Currently the tab tool tip is the tab's title.
The PR teaches the TabBase to check if there is a switch to tab command
associated with the current tab index,
if so concatenates the the relevant mapping to the too tip.
Of course, prefers user defined bindings to the default ones.
Moved tool tip logic to TabBase so SettingsTab has tooltip as well.