-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore support for pasting files #16634
Conversation
6c058a1
to
c2bf907
Compare
Hey, the WinRT API was doing something for us that we didn't have to worry too much about! |
Ackchyually, we had to do it manually: terminal/src/cascadia/TerminalApp/TerminalPage.cpp Lines 2620 to 2629 in 78de114
That's effectively the |
return {}; | ||
} | ||
|
||
auto buffer = winrt::impl::hstring_builder{ cap }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shouldn't use winrt::impl
types directly. However, I don't love any of the other options. heh
|
TIL: You could Ctrl+V files into Windows Terminal and here I am, always opening the context menu and selecting "Copy as path"... smh This restores the support by adding a very rudimentary HDROP handler. The flip side of the regression is that I learned about this and so conhost also gets this now, because why not! Closes #16627 * Single files can be pasted in WT and conhost ✅ (cherry picked from commit ef96e22) Service-Card-Id: 91727725 Service-Version: 1.19
TIL: You could Ctrl+V files into Windows Terminal and here I am, always opening the context menu and selecting "Copy as path"... smh This restores the support by adding a very rudimentary HDROP handler. The flip side of the regression is that I learned about this and so conhost also gets this now, because why not! Closes #16627 ## Validation Steps Performed * Single files can be pasted in WT and conhost ✅ (cherry picked from commit ef96e22) Service-Card-Id: 91727726 Service-Version: 1.20
TIL: You could Ctrl+V files into Windows Terminal and here I am,
always opening the context menu and selecting "Copy as path"... smh
This restores the support by adding a very rudimentary HDROP handler.
The flip side of the regression is that I learned about this and so
conhost also gets this now, because why not!
Closes #16627
Validation Steps Performed