-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Progress ring color based on the status from the running process #15847
Conversation
(I'm just gonna mark this as a draft while you work on this 😝 ) |
my 2c even though I'm out today: I think the default should still be your accent color / whatever the default color is. The others look sweet though |
my 2c even though I'm gonna be out this afternoon: I love it, but I am worried about how it looks in high contrast or in other conditions where the user has color overrides :) |
const auto color = | ||
(taskbarState == 2) ? | ||
winrt::Windows::UI::Colors::Red() : | ||
((taskbarState == 4) ? | ||
winrt::Windows::UI::Colors::Orange() : | ||
winrt::Windows::UI::Colors::Green()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd prefer a switch
statement here for readability!
Also for tastbarState = 3
we should probably set it to the default color (it currently adopts the color based on the previous state, so it could be any of red/orange/green depending).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other notes:
- Let's leave the default (
0
) and the indeterminate(3
) state just the accent color. - We need to use ThemeResources here. I think
InfoBar
uses theme brushes for the background, but those are more muted colors. I dunno if InfoBadge has a good "Warning" color.
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Summary of the Pull Request
Currently Terminal ignores the state flag passed from the VT progress sequence.
Errors
Warning
Normal
References and Relevant Issues
#6700
Detailed Description of the Pull Request / Additional comments
This change changes the default color of the progress ring to green. If errors are sent then the color changes to red. If warnings are detected the color changes to orange.
Validation Steps Performed
Tested end to end with tools that sends status updates.
PR Checklist