Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add scrollHome and scrollEnd #7542

Closed
vefatica opened this issue Sep 5, 2020 · 3 comments · Fixed by #8459
Closed

Please add scrollHome and scrollEnd #7542

vefatica opened this issue Sep 5, 2020 · 3 comments · Fixed by #8459
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@vefatica
Copy link

vefatica commented Sep 5, 2020

Description of the new feature/enhancement

actions:
scrollHome - scroll to earliest history
scrollEnd - return to input line

Proposed technical implementation details (optional)

bindings:
scrollHome - Ctrl+Shift+Home
scrollEnd - Ctrl+Shift+End
@vefatica vefatica added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 5, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 5, 2020
@DHowett DHowett added Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Sep 9, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 9, 2020
@DHowett
Copy link
Member

DHowett commented Sep 9, 2020

Proposal: scrollToTop and scrollToBottom.
Counterbalance: selectAll (part of #715)

If there was a special mode, selection mode, that you could enter and it would let you move around the cursor with all your keys... would that be acceptable?

If so, #5804 is a spec for that mode. 😄

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 9, 2020
@vefatica
Copy link
Author

vefatica commented Sep 9, 2020

It's not a matter of acceptability. I didn't follow that thread well. I don't want to move the cursor; I want to scroll the history. If you're suggesting more than one keystroke to scroll the history, I won't like it. Up, down, pgup and pgdn are fine as they are ... it just needs a couple more.

@vadimkantorov
Copy link

This would be very useful, since when the program prints very fast and scrollbar isn't at very bottom, then it's impossilbe to dock it back to bottom, since printing is faster than human moving the scrollbar

@ghost ghost mentioned this issue Dec 2, 2020
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Dec 2, 2020
@ghost ghost closed this as completed in #8459 Dec 8, 2020
ghost pushed a commit that referenced this issue Dec 8, 2020
@kaihugo
Add ScrollHome and ScrollEnd (#8459)
0b88694 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
This PR adds shortcut action so that users can scroll.
I used `UINT16_MAX` for `rowsToScroll`.
<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #7542
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Dec 8, 2020
mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
@kaihugo @mpela81
Add ScrollHome and ScrollEnd (microsoft#8459)
025acfd 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
This PR adds shortcut action so that users can scroll.
I used `UINT16_MAX` for `rowsToScroll`.
<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes microsoft#7542
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ScrollHome and ScrollEnd
3 participants
@DHowett @vadimkantorov @vefatica