Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launching in Focus mode doesn't start at the correct size #10730

Closed
Tracked by #3486
vefatica opened this issue Jul 20, 2021 · 3 comments · Fixed by #17068
Closed
Tracked by #3486

Launching in Focus mode doesn't start at the correct size #10730

vefatica opened this issue Jul 20, 2021 · 3 comments · Fixed by #17068
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@vefatica
Copy link

Is there any plan to make focus mode respect the number of rows and padding settings, especially at startup?
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 20, 2021
@DHowett
Copy link
Member

DHowett commented Jul 20, 2021

Given that nobody's ever told us that it didn't do so, there was no plan to. After all, we can't plan for something we don't know needs to be done.

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 20, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 20, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jul 20, 2021
@zadjii-msft zadjii-msft changed the title Focus mode, rows, padding? Launching in Focus mode doesn't start at the correct size Jul 20, 2021
@vefatica
Copy link
Author

OK, it doesn't. My preference would be that focus mode (startup too) remove the tab portion of the window, making it smaller but respecting the rows and paddings settings (as opposed to converting the tab portion to output).

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 22, 2021
@zadjii-msft zadjii-msft mentioned this issue Nov 29, 2021
Closed
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Apr 4, 2022
Open
9 tasks
@zadjii-msft
Copy link
Member

This may also be related to the fact that FOMO starts at the wrong size after a session restore. Fixing this might be the easiest way of fixing that, honestly.

@zadjii-msft zadjii-msft mentioned this issue Apr 16, 2024
Open
16 tasks
zadjii-msft added a commit that referenced this issue Apr 16, 2024
@zadjii-msft
Fix persisting the size of a focus mode window
2c24d67 
While I was fixing the initial position thing, I figured I'd fix this too. We
were mistakenly accounting for the size of the titlebar when we should launch
into focus mode (without one)

Closes #10730
@zadjii-msft zadjii-msft mentioned this issue Apr 16, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Apr 16, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 25, 2024
@zadjii-msft
Fix persisting the size of a focus mode window (#17068)
f36d589 
While I was fixing the initial position thing, I figured I'd fix this
too. We were mistakenly accounting for the size of the titlebar when we
should launch into focus mode (without one)

Closes #10730
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 25, 2024
DHowett pushed a commit that referenced this issue Apr 26, 2024
@zadjii-msft @DHowett
Fix persisting the size of a focus mode window (#17068)
464c0a3 
While I was fixing the initial position thing, I figured I'd fix this
too. We were mistakenly accounting for the size of the titlebar when we
should launch into focus mode (without one)

Closes #10730

(cherry picked from commit f36d589)
Service-Card-Id: 92410732
Service-Version: 1.20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix persisting the size of a focus mode window microsoft/terminal
3 participants
@DHowett @zadjii-msft @vefatica