Skip to content

Commit

Permalink
addressed feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
cinnamon-msft committed Apr 1, 2020
1 parent e90193c commit fa1e65b
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions doc/specs/#4191 - Formatted Copy/spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,21 @@ We could add an argument to the `copy` key binding to allow for formatted copyin

a. The user could list which kinds of formats they want included when they copy. When right clicking, they would copy with these formats. If this is set to something other than `plain`, holding `alt` and right clicking would copy plain text.

`"copyFormats": "html,rtf,plain"`
`"copyFormats": ["html","rtf","plain"]`

b. We could also just combine html and rtf into a single boolean. Users would either get plain text only (`false`) or all formatting (`true`) onto their clipboard. If this is set to `true`, the default right click behavior is reversed: right clicking copies the formatting and holding `alt` copies only the plain text.

`"copyFormatting": true`

### Settings option 2 - key binding argument

a. Just like the the `trimWhitespace` argument you can add to the `copy` key binding, we could add one for text formatting.
a. Just like the the `trimWhitespace` argument you can add to the `copy` key binding, we could add one for text formatting. This would not change the right click behavior.

`{"command": {"action": "copy", "keepFormatting": true}, "keys": "ctrl+a"}`

b. We could also split out the html and rtf formats.
b. We could also split out the html and rtf formats. The right click behavior would still stay as default.

`{"command": {"action": "copy", "formats": "rtf,html,plain"}, "keys": "ctrl+a"}`
`{"command": {"action": "copy", "formats": ["html","rtf","plain"]}, "keys": "ctrl+a"}`

## Capabilities

Expand Down Expand Up @@ -77,4 +77,6 @@ One possible issue is that discovering how to copy the formatting might be diffi

## Future considerations

We could add the option we don't include later if people want it. For example, if we ship a global setting now, we could ship a key binding later that lets you choose how you want to copy, and vice versa.

## Resources

0 comments on commit fa1e65b

Please sign in to comment.