pr nits, spellcheck

.github/actions/spell-check/patterns/patterns.txt

@@ -1,4 +1,4 @@
-https://(?:(?:[-a-zA-Z0-9?&=]*\.|)microsoft\.com)/[-a-zA-Z0-9?&=_\/.]*
+https://(?:(?:[-a-zA-Z0-9?&=]*\.|)microsoft\.com)/[-a-zA-Z0-9?&=_#\/.]*
 https://aka\.ms/[-a-zA-Z0-9?&=\/_]*
 https://www.w3.org/[-a-zA-Z0-9?&=\/_#]*
 https://(?:(?:www\.|)youtube\.com|youtu.be)/[-a-zA-Z0-9?&=]*

.github/actions/spell-check/whitelist/web.txt

@@ -4,3 +4,5 @@ www
 ecma
 rapidtables
 WCAG
+winui
+appshellintegration

.github/actions/spell-check/whitelist/whitelist.txt

@@ -2145,7 +2145,7 @@ SHIFTJIS
 Shl
 shlguid
 shlobj
-shlobjidl
+shobjidl
 shlwapi
 SHORTPATH
 SHOWCURSOR

src/cascadia/ShellExtension/OpenTerminalHere.cpp

@@ -47,53 +47,57 @@ bool IsDevBuild()
 //   for this instance of the shell extension. If we're running the dev build,
 //   it should be a `wtd.exe`, but if we're preview or release, we want to make
 //   sure to get the correct `wt.exe` that corresponds to _us_.
-// - If we're unpackaged, this needs to get us `windowsterminal.exe`, because
+// - If we're unpackaged, this needs to get us `WindowsTerminal.exe`, because
 //   the `wt*exe` alias won't have been installed for this install.
 // Arguments:
 // - <none>
 // Return Value:
-// - the full path to the exe, one of `wt.exe`, `wtd.exe`, or `windowsterminal.exe`.
+// - the full path to the exe, one of `wt.exe`, `wtd.exe`, or `WindowsTerminal.exe`.
 std::wstring _getExePath()
 {
-    // First, check a packaged location for the exe. If we've got a package
-    // family name, that means we're one of the packaged Dev build, packaged
-    // Release build, or packaged Preview build.
-    //
-    // If we're the preview or release build, there's no way of knowing if the
-    // `wt.exe` on the %PATH% is us or not. Fortunately, _our_ execution alias
-    // is located in "%LOCALAPPDATA%\Microsoft\WindowsApps\<our package family
-    // name>", _always_, so we can use that to look up the exe easier.
-    try
-    {
-        const auto package{ winrt::Windows::ApplicationModel::Package::Current() };
-        const auto id = package.Id();
-        const std::wstring pfn{ id.FamilyName() };
-        if (!pfn.empty())
+    // use C++11 magic statics to make sure we only do this once.
+    static const std::wstring exepath = []() -> std::wstring {
+        // First, check a packaged location for the exe. If we've got a package
+        // family name, that means we're one of the packaged Dev build, packaged
+        // Release build, or packaged Preview build.
+        //
+        // If we're the preview or release build, there's no way of knowing if the
+        // `wt.exe` on the %PATH% is us or not. Fortunately, _our_ execution alias
+        // is located in "%LOCALAPPDATA%\Microsoft\WindowsApps\<our package family
+        // name>", _always_, so we can use that to look up the exe easier.
+        try
         {
-            const std::filesystem::path windowsAppsPath{ wil::ExpandEnvironmentStringsW<std::wstring>(L"%LOCALAPPDATA%\\Microsoft\\WindowsApps\\") };
-            const std::filesystem::path wtPath = windowsAppsPath / pfn / (IsDevBuild() ? L"wtd.exe" : L"wt.exe");
-            return wtPath;
+            const auto package{ winrt::Windows::ApplicationModel::Package::Current() };
+            const auto id = package.Id();
+            const std::wstring pfn{ id.FamilyName() };
+            if (!pfn.empty())
+            {
+                const std::filesystem::path windowsAppsPath{ wil::ExpandEnvironmentStringsW<std::wstring>(L"%LOCALAPPDATA%\\Microsoft\\WindowsApps\\") };
+                const std::filesystem::path wtPath = windowsAppsPath / pfn / (IsDevBuild() ? L"wtd.exe" : L"wt.exe");
+                return wtPath;
+            }
         }
-    }
-    CATCH_LOG();
+        CATCH_LOG();
 
-    // If we're here, then we couldn't resolve our exe from the package. This
-    // means we're running unpackaged. We should just use the
-    // WindowsTerminal.exe that's sitting in the directory next to us.
-    try
-    {
-        HMODULE hModule = GetModuleHandle(nullptr);
-        THROW_LAST_ERROR_IF(hModule == nullptr);
-        std::wstring dllPathString;
-        THROW_IF_FAILED(wil::GetModuleFileNameW(hModule, dllPathString));
-        const std::filesystem::path dllPath{ dllPathString };
-        const std::filesystem::path rootDir = dllPath.parent_path();
-        std::filesystem::path wtPath = rootDir / "WindowsTerminal.exe";
-        return wtPath;
-    }
-    CATCH_LOG();
+        // If we're here, then we couldn't resolve our exe from the package. This
+        // means we're running unpackaged. We should just use the
+        // WindowsTerminal.exe that's sitting in the directory next to us.
+        try
+        {
+            HMODULE hModule = GetModuleHandle(nullptr);
+            THROW_LAST_ERROR_IF(hModule == nullptr);
+            std::wstring dllPathString;
+            THROW_IF_FAILED(wil::GetModuleFileNameW(hModule, dllPathString));
+            const std::filesystem::path dllPath{ dllPathString };
+            const std::filesystem::path rootDir = dllPath.parent_path();
+            std::filesystem::path wtPath = rootDir / "WindowsTerminal.exe";
+            return wtPath;
+        }
+        CATCH_LOG();
 
-    return L"wt.exe";
+        return L"wt.exe";
+    }();
+    return exepath;
 }
 
 // Method Description:
@@ -142,10 +146,10 @@ HRESULT OpenTerminalHere::Invoke(IShellItemArray* psiItemArray,
 }
 
 HRESULT OpenTerminalHere::GetToolTip(IShellItemArray* /*psiItemArray*/,
-                                     LPWSTR* ppszInfotip)
+                                     LPWSTR* ppszInfoTip)
 {
     // tooltip provided here, in this case none is provided
-    *ppszInfotip = nullptr;
+    *ppszInfoTip = nullptr;
     return E_NOTIMPL;
 }
 

src/cascadia/ShellExtension/OpenTerminalHere.h

@@ -28,13 +28,13 @@ Author(s):
 using namespace Microsoft::WRL;
 
 struct __declspec(uuid("9f156763-7844-4dc4-bbb1-901f640f5155"))
-    OpenTerminalHere : public RuntimeClass<RuntimeClassFlags<ClassicCom>, IExplorerCommand>
+    OpenTerminalHere : public RuntimeClass<RuntimeClassFlags<ClassicCom | InhibitFtmBase>, IExplorerCommand>
 {
 #pragma region IExplorerCommand
     HRESULT Invoke(IShellItemArray* psiItemArray,
-                   IBindCtx* pbc);
+                   IBindCtx* pBindContext);
     HRESULT GetToolTip(IShellItemArray* psiItemArray,
-                       LPWSTR* ppszInfotip);
+                       LPWSTR* ppszInfoTip);
     HRESULT GetTitle(IShellItemArray* psiItemArray,
                      LPWSTR* ppszName);
     HRESULT GetState(IShellItemArray* psiItemArray,