handle hierarchyid correctly #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charles-Gagnon
approved these changes
Mar 31, 2022
This was referenced Apr 14, 2022
nofield
pushed a commit
that referenced
this pull request
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes: microsoft/azuredatastudio#18154
the sql datatype for hierarchyid has always been nvarchar here, but previously we were not relying on it. Now we are using SqlDataType to decide how to handle the serialization/deserialization,.
fix:
treat it as binary and added test for it.
also added test for sysname data type that were handled specially but do not have test coverage.
before:
after:
SSMS:
