Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert simple Join-Path syntax #2459

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

shaopeng-gh
Copy link
Collaborator

@shaopeng-gh shaopeng-gh commented Feb 18, 2022

Description:

I did noticed CodeQL task does not recognize simplified syntax and report as fail,
but there is also a .compliance task will fail, look like because of this CodeQL fail.
Suggest just revert that simplified syntax.

image

It looks that that task is running in old version of PowerShell:
image

Fixes:

Revert changes made for simplified syntax of Join-Path.

@shaopeng-gh shaopeng-gh marked this pull request as ready for review February 18, 2022 03:44
Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelcfanning michaelcfanning merged commit 525a250 into main Feb 18, 2022
@michaelcfanning michaelcfanning deleted the users/shaopeng-gh/fixcodeqlfail branch February 18, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants