Eliminate whitespace and commas from MongoDB match candidates (and resulting fingerprints). #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is this documented in the release notes? Also, please note the update I made to this PR, let's try to be a bit more descriptive. |
michaelcfanning
changed the title
|
I first open the PR and do a second commit adding the releasehistory to get the #. I will also update the releasehistory with that. In reply to: 915524691 |
|
Here's the title I chose: Eliminate whitespace and commas from MongoDB match candidates (and resulting fingerprints). If we work together on good titles, these also serve as good candidates for the release notes documentation. In reply to: 915524691 |
Src/ReleaseHistory.md
Outdated
| `SEC101/036.MySqlCredential`, `SEC101/037.SqlCredentials`, | ||
| `SEC101/038.PostgreSqlCredentials` won't accept spaces in `id` and `secret`. | ||
| [#550](https://github.com/microsoft/sarif-pattern-matcher/pull/550) | ||
| - FPC: Improving MongoDB regular expression removing hosts that contain `\s` or | ||
| `,` characters. |
There was a problem hiding this comment.
'Eliminate whitespace and characters from MongoDB host matches (and resulting fingerprints)'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
ReleaseHistory.mdupdated for non-trivial changes