Single match expression should run multiple regex types #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
commented
Sep 8, 2021
| @@ -454,24 +454,32 @@ private static void MergeDictionary(IList<Dictionary<string, FlexMatch>> mergeFr | |||
|
|
|||
| private void RunMatchExpression(FlexMatch binary64DecodedMatch, AnalyzeContext context, MatchExpression matchExpression) | |||
| { | |||
| bool isMalformed = true; | |||
eddynaka
commented
Sep 8, 2021
| @@ -314,9 +314,9 @@ private Assembly CurrentDomain_AssemblyResolve(object sender, ResolveEventArgs a | |||
| // We will only attempt to resolve an assembly a single time | |||
| // to avoid re-entrance in cases where our logic below fails | |||
| string assemblyName = args.Name.Split(',')[0]; | |||
| if (this._resolvedNames.ContainsKey(assemblyName)) | |||
| if (this._resolvedNames.TryGetValue(assemblyName, out resolved)) | |||
eddynaka
changed the title
eddynaka
changed the title
Src/ReleaseHistory.md
Outdated
| @@ -22,6 +22,8 @@ | |||
| `SEC101/036.MySqlCredential`, `SEC101/037.SqlCredentials`, | |||
| `SEC101/038.PostgreSqlCredentials` won't accept spaces in `id` and `secret`. | |||
| [#550](https://github.com/microsoft/sarif-pattern-matcher/pull/550) | |||
| - PRF: Single match expression can run multiple regex types. | |||
|
|
||
| if (matchExpression.IntrafileRegexes?.Count > 0 || | ||
| matchExpression.SingleLineRegexes?.Count > 0) | ||
| else |
| @@ -314,9 +314,9 @@ private Assembly CurrentDomain_AssemblyResolve(object sender, ResolveEventArgs a | |||
| // We will only attempt to resolve an assembly a single time | |||
| // to avoid re-entrance in cases where our logic below fails | |||
| string assemblyName = args.Name.Split(',')[0]; | |||
| if (this._resolvedNames.ContainsKey(assemblyName)) | |||
| if (this._resolvedNames.TryGetValue(assemblyName, out resolved)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
ReleaseHistory.mdupdated for non-trivial changes