Add rank to all results (which is the normalized shannon entropy of t… #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he password/key component of the fingerprint).
michaelcfanning
commented
Mar 25, 2021
| /// be used to compute the rank of the fingerprint (which is itself | ||
| /// the normalized Shannon entropy of the key or password). | ||
| /// </summary> | ||
| public int SecretSymbolSetCount { get; set; } |
There was a problem hiding this comment.
SecretSymbolSetCount [](start = 19, length = 20)
Note that this change can't really be leveraged until we make another change which is to simply return a Fingerprint value from every analysis method. We previously used a string in order to avoid taking a dependency on the type, but no that we have an SDK it's silly to translate everything through a string return value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he password/key component of the fingerprint).
@cfaucon @eddynaka @jameswinkler