Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(test-repos): Add a test monorepo under /test-repos/yarn-pnpm #3507

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

JasonVMo
Copy link
Contributor

@JasonVMo JasonVMo commented Feb 5, 2025

Description

There are several tools built in rnx-kit that it would be beneficial to test in a separate repo. This creates a separate monorepo, set up with yarn in pnpm mode under /test-repos/yarn-pnpm. This will allow us to leverage tools built in rnx-kit and test them out in various configurations.

  • In particular this is essential for being able to test the yarn plugin for external workspaces currently active as a draft PR.

Currently this test repo isn't included in CI loops, as it is pulling in rnx-kit packages via npm, but that will be added once it is in a nice state and is actually testing out some of the tools directly. Ideally it will reference the rnx-kit packages via the external workspaces plugin.

For the repo itself:

  • it has an eslint-config package, two controls copied and adapted from FURN (button and text), then the test-app code split into three packages, test-app-shared, test-app-desktop, and test-app-mobile.
  • scripts is set up in much the same fashion as for rnx-kit itself.
  • yarn is in pnpm mode
  • right now only the build/lint scripts are working. The bundle commands route to the rnx-cli correctly but I haven't worked through the issues.
  • It uses lage for builds rather than nx since it let's us test the tool that is more common internally.

@JasonVMo JasonVMo changed the title feat(test-repos): Add a test monorepo under /test-repos/yarn-pnpm test(test-repos): Add a test monorepo under /test-repos/yarn-pnpm Feb 5, 2025
Comment on lines +59 to +60
"@rnx-repo-yarn-pnpm/eslint-config": "workspace:*",
"@rnx-repo-yarn-pnpm/scripts": "workspace:*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use portal: instead of copying these two packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scripts will be not quite the same but I can make that adjustment for the eslint-config package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package folder should be all lower-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants