Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add std feature #231

Merged
merged 1 commit into from
May 9, 2024
Merged

add std feature #231

merged 1 commit into from
May 9, 2024

Conversation

anakrish
Copy link
Collaborator

@anakrish anakrish commented May 9, 2024

  • std feature is enabled by default
  • By default enable #![no_std] compilation
  • Import std create if std feature is enabled or if testing
  • Use core, alloc types
  • Make it clear where std types are being used
  • In no std, use BTreeMap in place of HashMap. HashMap is not available in no std due to lack of a secure random number generator

Note: The project does not yet compile without std feature being specified. But it's really close to being able to do so.

- `std` feature is enabled by default
- By default enable #![no_std] compilation
- Import std create if `std` feature is enabled or if testing
- Use core, alloc types
- Make it clear where std types are being used
- In no std, use BTreeMap in place of HashMap.
   HashMap is not available in no std due to lack of a
   secure random number generator

Note: The project does not yet compile without std feature being specified.
But it's really close to being able to do so.

Signed-off-by: Anand Krishnamoorthi <[email protected]>
@anakrish anakrish requested a review from mkulke May 9, 2024 00:49
@anakrish
Copy link
Collaborator Author

anakrish commented May 9, 2024

Merging to make progress.

@anakrish anakrish merged commit 01fc234 into microsoft:main May 9, 2024
4 checks passed
@anakrish anakrish deleted the more-no-std branch May 9, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant