-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby bindings for existing FFI methods, plus eval_rule() #188
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
I don't quite follow the Ruby details; but will try it out locally.
The PR title could be updates as well.
Looks great, especially if this is the first time with Rust! |
…DME.md also added rubocop-minitest and rubocop-rake, and added more test coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for this contribution!
@@ -0,0 +1,180 @@ | |||
# frozen_string_literal: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests.
I have created an issue #191. You could also update the bindings section of the main README.md |
There are a few other things I haven't gotten to yet besides adding the Ruby bindings tests to the github actions, but I think these could each be followup PRs.
@anakrish thank you so much for the feedback! |
@thedavemarshall I will go ahead and merge the PR. The remaining items including the github action could be done as separate PRs. |
Interesting! |
I have a few things left to figure out, but I wanted to get some early feedback on my first time wring Rust. Feedback is welcome!
The other thing I'd call out is that I ran into some issues with a circular build when I had thebindings/ruby/ext/regorusrb/Cargo.toml
depend on the relative location ofregorus
, so I locked it to0.1.2
. Other language bindings seem to work with the relative paths, I think this might be something to do with the other manifest atbindings/ruby/Cargo.toml
? Not sure if resolving this is a blocker or if we can manually update the versions as needed for each release.Update- I think I got it to work with relative paths for the crate!
The other callout is that rubygems expects a
Cargo.lock
file to be included, source, which in this case is the top level regorus crate's Cargo.lock