arc feature to enable using Engine and other data structures from multiple threads
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`arc` is turned on by default. When enabled, std::sync::Arc will be used instead of std::rc::Rc. The former makes regorus types like Engine, Value, ast nodes etc Send, allowing for usability from multiple threads. Arc would add a performance overhead though since the reference counting will now become atomic. Signed-off-by: Anand Krishnamoorthi <[email protected]>
Signed-off-by: Anand Krishnamoorthi <[email protected]>
Signed-off-by: Anand Krishnamoorthi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
arcfeature,std::sync::Arcinstead of non-atomic reference counters. This allowsEngine,Valueand other types to be shared across multiple threads. There would still need to be a mutex if amut Engineneeds to be shared across threads.The
arcfeature is turned on by default.The user can choose to:
arcand use atomic reference counters which might cost a bit of performance. This cost may not matter for many use-cases.arcand use single threaded reference counters.EngineandValuecannot be shared across threads. Values could be converted to json to pass between threads.Also
Enginedebug.