Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement builtin time.parse_duration_ns method #100

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Implement builtin time.parse_duration_ns method #100

merged 2 commits into from
Jan 8, 2024

Conversation

unexge
Copy link
Contributor

@unexge unexge commented Jan 8, 2024

Part of #72.

I ported Go's time.ParseDuration to Rust and added Go's license to compat.rs but not sure if this is sufficient.

anakrish
anakrish approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@anakrish anakrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for closing out the time builtins!

@anakrish anakrish merged commit 49bd657 into microsoft:main Jan 8, 2024
2 checks passed
@unexge unexge deleted the parse-duration branch January 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakrish anakrish anakrish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unexge @anakrish