Switch to MUX:TextCommandBarFlyout in XAML Islands proofing menu #8723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the broken keyboard navigation in an islands app, however it can cause a crash when using WinUI 2.6 (but is fixed in WinUI 2.7). Closes microsoft#8306
ghost
added
|
The crash when using WinUI 2.6: microsoft/microsoft-ui-xaml#5680 |
|
Since we can get a crash when the flyout closes in WinUI 2.6, we can probably wait to check this in until "after" we upgrade to WinUI 2.7, tracked by issue: #8724 |
jonthysell
changed the title
|
Note that this will exacerbate another XAML bug: microsoft/microsoft-ui-xaml#5818. I wonder if we should wait until there's a fix to that before landing this or put in the workaround I mention in that issue into this PR? |
|
Waiting for 2.7 PR here: #8726 |
lyahdav
reviewed
Sep 28, 2021
jonthysell
added
the
AutoMerge
|
Hello @jonthysell! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
jonthysell
removed
the
AutoMerge
asklar
approved these changes
Oct 26, 2021
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Oct 26, 2021
…nu (microsoft#8723) This fixes the broken keyboard navigation in an islands app, however it can cause a crash when using WinUI 2.6 (but is fixed in WinUI 2.7, which was just checked in). Closes microsoft#8306 Co-authored-by: Liron Yahdav <[email protected]>
ghost
pushed a commit
that referenced
this pull request
Oct 27, 2021
…nu (#8723) (#8944) This fixes the broken keyboard navigation in an islands app, however it can cause a crash when using WinUI 2.6 (but is fixed in WinUI 2.7, which was just checked in). Closes #8306 Co-authored-by: Liron Yahdav <[email protected]> Co-authored-by: Liron Yahdav <[email protected]> Co-authored-by: Nick Gerleman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the broken keyboard navigation in an islands app, however it can cause a crash when using WinUI 2.6 (but is fixed in WinUI 2.7).
Closes #8306
Microsoft Reviewers: Open in CodeFlow