-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around XAML Islands issues with TextCommandBarFlyout #8249
Conversation
b80702e
to
98540d7
Compare
As reported in microsoft/microsoft-ui-xaml#5341, the singleton TextCommandBarFlyout for the XAML TextBox and TextBlock components are limited to one window. When the flyout opens on a different window after already being opened on another, the first window the flyout was opened on gets focus, and the flyout is immediately closed. This change creates a TextCommandBarFlyout per TextInput native view and per selection TextBlock native view.
98540d7
to
ae2d021
Compare
33c73d1
to
2de3624
Compare
vnext/Microsoft.ReactNative/Microsoft.ReactNative.vcxproj.filters
Outdated
Show resolved
Hide resolved
a01d4a9
to
93fa45e
Compare
93fa45e
to
a707b66
Compare
Easy way to repro these issues in playground-win32:
|
@rozele is this one ready for merge? |
@NickGerleman - going to implement @lyahdav's suggestion, then this should be ready 😅 Update: now it should be ready :) |
cf3346d
to
157d170
Compare
@NickGerleman Any update on this? It's blocking another PR I'd like to submit. |
Sorry, missed the notification that it is ready for merge. I don't think GH updates send notifications, so feel free to give me a mention is there is a change to an older PR, and I will take a look. |
As reported in microsoft/microsoft-ui-xaml#5341, the singleton TextCommandBarFlyout for the XAML TextBox and TextBlock components are limited to one window. When the flyout opens on a different window after already being opened on another, the first window the flyout was opened on gets focus, and the flyout is immediately closed. This change creates a TextCommandBarFlyout per TextInput native view and per selection TextBlock native view.
Additionally, it includes logic to work around an issue with the Proofing sub-menu flyout, which crashes due to an animation bug on Windows 10 versions lower than 21H1.
Microsoft Reviewers: Open in CodeFlow