-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ReactWindowsCore projects #5012
Conversation
@vmoroz I have scaled down the size of this change:
C.C. @asklar |
@@ -4,7 +4,7 @@ | |||
#include <winrt/facebook.react.h> | |||
|
|||
namespace facebook::react { | |||
class MessageQueueShim : public MessageQueueThread { | |||
class MessageQueueShim : public facebook::react::MessageQueueThread { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JunielKatarn Please make a corresponding update to the docs repo for native modules setup to indicate that this project is no longer present nor necessary. If this is getting backported to 62, you'll want to make these changes now, before the website releases the 62 docs. Otherwise, you want to wait until after the website snaps to 62, and then update the docs. |
@jonthysell certainly. I'll address this today. |
Removing the |
We discussed this in triage and decided not to backport the change. It's nice to have but will also cause a breaking change to the template project |
Source folder and projects ReactWindowsCore have become redundant, and only increase project structure complexity:
Shared\Shared.vcxitems
.ReactWindowsCore.vcxproj
andReactWindowsCore-Desktop.vcxproj
.These were directly consumed ONLY by their corresponding Desktop and Universal projects, thus adding no build benefit over a shared items project (i.e.
Shared.vcxitems
).This change simplifies the solution structure moving the shared source files into their intended project.
Note: This change seems rather large, but it's only because sources are moved from the
ReactWindowsCore
subdirectory toShared
.Microsoft Reviewers: Open in CodeFlow