-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of override tooling #4158
Conversation
Add a foundation for new override tooling described in microsoft#4104. This includes: - Build scripts, lint scripts, config files, etc - Logic for parsing and checking validity of an override manifest - Unit tests for override manifest logic - Abstractions to allow fetching React Native files of arbtrary versions A lot of this is foundational. The override logic has been well-tested, and the Git logic has been manually tested, but we don't have much end-to-end set up yet.
@acoates-ms do we have a nice way to hook in jest tests for a package into CI? Having tests locally only for just this isn't too bad, but if it's easy, I would rather add JS tests to there as well. |
We should introduce a new top level command for "test", which would run UTs. Then pick one of the CI slices to trigger the test command. (I generally look at which one is currently quickest). -- you'll want to make sure its one of the ones that has already done yarn build. .. Then only other tricky part is that it looks like E2E test package is already using the test script for something. ... So then I guess either pick a different name than test either for the new task, or rename the existing E2E one, which probably also means modifying the CI loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like using the just-task template actually puts unit tests as part of the build. This seems reasonable, since on my machine it takes 5s to run tests without the jest cache. That should get us CI coverage without any extra work. |
Hello @NickGerleman! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
We hardcode an old version of WebderiverIO beacuse of microsoft#3019. These seem to have loose dependency requirements, because the change to deuplicate packages broke this (see webdriverio/webdriverio#4104). Hardcode resolutions in E2ETest for existing versions of wdio packages in the meantime.
Add a foundation for new override tooling described in #4104. This includes:
A lot of this is foundational. The override logic has been well-tested,
and the Git logic has been manually tested, but we don't have much
end-to-end set up yet.
Microsoft Reviewers: Open in CodeFlow