Add GetFacebookReactInstance #3782

ZihanChen-MSFT · 2019-12-16T22:21:32Z

To get facebook::react::Instance from uwp::Instance

The reason not to do this directly in client application is, it requires the client application to include too many header files that are not designed to be included out side of ReactUWP, and it requires the client application to do too many configuration in its vcxproj file, which is not practical for consumers.

An uwp::Instance is needed for turbo module users for registering native module implementations.

Microsoft Reviewers: Open in CodeFlow

* Update E2ETest to use ReactApplication * Minor update * Remove generating pch.pch * Change files * Shrink pch file size for Microsfot.ReactNative * Revert "Remove generating pch.pch" This reverts commit 39286c8. * fix build * Update Timeout

Documentation update based on #2852 completion

Bumps [@microsoft/api-extractor](https://github.com/microsoft/rushstack) from 7.6.1 to 7.7.0. - [Release notes](https://github.com/microsoft/rushstack/releases) - [Commits](https://github.com/microsoft/rushstack/compare/@microsoft/api-extractor_v7.6.1...@microsoft/api-extractor_v7.7.0) Signed-off-by: dependabot-preview[bot] <[email protected]>

Bumps [@microsoft/api-documenter](https://github.com/microsoft/rushstack) from 7.6.1 to 7.7.2. - [Release notes](https://github.com/microsoft/rushstack/releases) - [Commits](https://github.com/microsoft/rushstack/compare/@microsoft/api-documenter_v7.6.1...@microsoft/api-documenter_v7.7.2) Signed-off-by: dependabot-preview[bot] <[email protected]>

* Re-aligned SampleAppCPP project to match the others, #3728 * Updated all projects to 2.0.190730.2

Bumps [@types/react-native](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-native) from 0.60.22 to 0.60.24. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-native) Signed-off-by: dependabot-preview[bot] <[email protected]>

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 10.17.6 to 10.17.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <[email protected]>

update instructions on how to install submodules in the case where you started out working on vnext then switched to current.

…1.6 (#3729) * unify hermes and v8jsi version * Change files * use HERMES_Package and V8_Package * remove them from reactuwp project

* reduce build time * changes * fix pipeline failure * use Add-AppxPackage * E2E test still use windows-2019 image * force install vs dependencies on vs2019 image for E2E test * parameters.forceVSDependencies * add ../../.ado/variables/vs2017.yml * Revert "add ../../.ado/variables/vs2017.yml" This reverts commit b829251. * revert and force * Fix pipeline error

* Add react-native-win32 package

* Miscellaneous fixes in ETW tracing and Systrace * Miscellaneous fixes in ETW tracing and Systrace - Adding missing files * Submitting the ETW schema resouce dll and the register script * Change files

…Reader, JSValue, and IJSValueWriter (#3760) * Merged implementation of strongly typed value serialization and deserialization using IJSValueReader, JSValue, and IJSValueWriter * Change files * Updated CLI template for C++ native modules

* Update to [email protected] * Change files * Change files

* Fix toggle debugger setting issue with ReactApplication

* delete pch after build

#3813) * Export ability to query native module names This is needed for testability (intenral CR using it out now). It's not ideal to add more exports, but we will always have to have some between instance interfaces. * Change files * Fix x86 mangeled name

* Changed Microsoft.ReactNative to be independent from ReactUWP * Removed ReactUWP project from the ReactUWPTestApp to reduce compiled code size. * Removed commented code from pch.h * Moved WindowsBrushExample.windows.tsx to fix RNTester bundle building * Updated TreeDumps to fix test cases. * An attempt to fix E2ETest * Changed ViewPanel naemspace in the E2ETest tree dumps * Changed namespace for ViewPanel in other E2ETest tree dumps

* check UAP in SDK10 installation folder

* add InjectBundleContent target * Change files * format

Bumps [@types/react-native](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-native) from 0.60.25 to 0.60.28. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-native) Signed-off-by: dependabot-preview[bot] <[email protected]>

Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. **This update includes a security fix.** - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.1.2...v4.5.3) Signed-off-by: dependabot-preview[bot] <[email protected]>

…#3829) * Call StartAnimatiom on m_scaleCombined for ScaleX / ScaleY animations There was a copy-paste error previously that started m_translationCombined instead. * Change files

* Remove remaining need for fork of RN for win32 JS * Change files * Build fix * Change files * Enable flow type checking in win32 * Fix build

…ve-windows into add-tm

packages/react-native-win32/just-task.js

vnext/just-task.js

vnext/ReactUWP/TurboModule/TurboModuleUtils.cpp

licanhua · 2020-01-08T23:21:00Z

vnext/ReactUWP/TurboModule/TurboModuleUtils.cpp

+    const winrt::react::uwp::Instance &uwpInstance) {
+  auto abiInstance = reinterpret_cast<ABI::react::uwp::Instance *>(winrt::get_abi(uwpInstance));
+  auto reactInstance = abiInstance->getInstance();
+  assert(reactInstance);


Personally I prefer if-else over assert.

I think it's fine, it can't fail, or it is a bug. So I prefer to crash.

vnext/ReactUWP/TurboModule/TurboModuleUtils.cpp

ghost · 2020-01-09T12:51:47Z

Hello @ZihanChen-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ZihanChen-MSFT and others added 30 commits December 9, 2019 16:39

GetFacebookReactInstance

58d7462

def

be62f8f

...

62e99ab

Add __cdecl explicitly

05efde7

Update ReactUWP.vcxproj

a48ce9a

applying package updates ***NO_CI***

4be30ff

Update ParityStatus.md (#3555)

389b1e8

Documentation update based on #2852 completion

Aligning Microsoft.Windows.CppWinRT Versions (#3733)

647f988

* Re-aligned SampleAppCPP project to match the others, #3728 * Updated all projects to 2.0.190730.2

applying package updates ***NO_CI***

252434a

Update CONTRIBUTING.md

13f13d7

update instructions on how to install submodules in the case where you started out working on vnext then switched to current.

Use ReactNative.V8JSI.Windows.0.1.6 and ReactNative.Hermes.Windows.0.…

fd02682

…1.6 (#3729) * unify hermes and v8jsi version * Change files * use HERMES_Package and V8_Package * remove them from reactuwp project

applying package updates ***NO_CI***

2d77e1f

Add react-native-win32 package (#3762)

2e30bad

* Add react-native-win32 package

Publish packages using access public

ab16dc0

applying package updates ***NO_CI***

0071c7b

Miscellaneous fixes in ETW tracing and Systrace (#3745)

d5fe42f

* Miscellaneous fixes in ETW tracing and Systrace * Miscellaneous fixes in ETW tracing and Systrace - Adding missing files * Submitting the ETW schema resouce dll and the register script * Change files

applying package updates ***NO_CI***

b9c3c55

applying package updates ***NO_CI***

d1f70ed

Update to [email protected] (#3769)

024d35f

* Update to [email protected] * Change files * Change files

applying package updates ***NO_CI***

3b5cc34

Fix toggle debugger setting issue with ReactApplication (#3767)

7190da1

* Fix toggle debugger setting issue with ReactApplication

applying package updates ***NO_CI***

d99775e

Delete .pch after build on pipeline (#3771)

ba05046

* delete pch after build

NickGerleman and others added 17 commits January 7, 2020 13:46

applying package updates ***NO_CI***

c8ccf61

applying package updates ***NO_CI***

f9fcc02

Allow UAP SDK to be in other folder other than ProgramFiles (#3815)

b89bd04

* check UAP in SDK10 installation folder

applying package updates ***NO_CI***

b2ab0c2

Add InjectBundleContent target (#3821)

c45c827

* add InjectBundleContent target * Change files * format

applying package updates ***NO_CI***

caeaaf7

Call StartAnimation on m_scaleCombined for ScaleX / ScaleY animations (…

5c3f4c3

…#3829) * Call StartAnimatiom on m_scaleCombined for ScaleX / ScaleY animations There was a copy-paste error previously that started m_translationCombined instead. * Change files

applying package updates ***NO_CI***

d8352a9

Remove remaining need for fork of RN for win32 JS (#3834)

499403d

* Remove remaining need for fork of RN for win32 JS * Change files * Build fix * Change files * Enable flow type checking in win32 * Fix build

applying package updates ***NO_CI***

b055943

Rename GetFacebookReactInstance

e6191b8

Merge branch 'master' into add-tm

2c4ed97

Merge branch 'add-tm' of https://github.com/ZihanChen-MSFT/react-nati…

af31d87

…ve-windows into add-tm

jonthysell requested a review from vmoroz January 7, 2020 22:32

acoates-ms reviewed Jan 8, 2020

View reviewed changes

packages/react-native-win32/just-task.js Outdated Show resolved Hide resolved

acoates-ms reviewed Jan 8, 2020

View reviewed changes

vnext/just-task.js Outdated Show resolved Hide resolved

Fix code review comment

bd46b38

licanhua reviewed Jan 8, 2020

View reviewed changes

vnext/ReactUWP/TurboModule/TurboModuleUtils.cpp Outdated Show resolved Hide resolved

Update TurboModuleUtils.cpp

3481685

licanhua reviewed Jan 8, 2020

View reviewed changes

vnext/ReactUWP/TurboModule/TurboModuleUtils.cpp Show resolved Hide resolved

licanhua approved these changes Jan 9, 2020

View reviewed changes

Fix lint errors

be69794

ZihanChen-MSFT added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jan 9, 2020

ghost merged commit 1f8aea3 into microsoft:master Jan 9, 2020

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GetFacebookReactInstance #3782

Add GetFacebookReactInstance #3782

ZihanChen-MSFT commented Dec 16, 2019 •

edited

Loading

licanhua Jan 8, 2020

ZihanChen-MSFT Jan 9, 2020

ghost commented Jan 9, 2020

Add GetFacebookReactInstance #3782

Add GetFacebookReactInstance #3782

Conversation

ZihanChen-MSFT commented Dec 16, 2019 • edited Loading

Microsoft Reviewers: Open in CodeFlow

licanhua Jan 8, 2020

Choose a reason for hiding this comment

ZihanChen-MSFT Jan 9, 2020

Choose a reason for hiding this comment

ghost commented Jan 9, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ZihanChen-MSFT commented Dec 16, 2019 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.