TurboModule spec checking should accept hstring for string arguments #14322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Jan 31, 2025
…icrosoft#14322) * TurboModule spec checking should accept hstring for string arguments * Change files * example
acoates-ms
added a commit
that referenced
this pull request
Feb 1, 2025
* [Fabric] Fix PlatformColor (#14325) * Fix platform color * Change files * Add missing theme colors * snapshots * TurboModule spec checking should accept hstring for string arguments (#14322) * TurboModule spec checking should accept hstring for string arguments * Change files * example * change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If you have a turbo module spec that defines a method as taking a string parameter, then you should be able to use an
hstringon the native side.Currently the module works correctly when using an
hstring, but if you use the codegen'd spec to validate that the native TurboModule correctly implements the methods from JS, the build will fail because it does not correctly identifyhstringas being a valid argument type for a JS string.As an example the built in Clipboard module is currently using
std::wstring. Changing it tohstringwithout this change will cause the build to fail.Microsoft Reviewers: Open in CodeFlow