Only build OfficeReact.Win32 with UseFabric enabled #14319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
reviewed
Jan 29, 2025
| @@ -155,9 +139,6 @@ jobs: | |||
| Write-Host "##vso[task.setvariable variable=Desktop.IntegrationTests.Filter]$newValue" | |||
| displayName: Update Desktop.IntegrationTests.Filter to exclude RNTester integration tests | |||
|
|
|||
| - ${{ if eq(matrix.UseFabric, true) }}: | |||
| - template: ../templates/enable-fabric-experimental-feature.yml | |||
There was a problem hiding this comment.
I think you can delete enable-fabric-experimental-feature.yml too?
There was a problem hiding this comment.
No, we use it for Universal
acoates-ms
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes our build system to only build the version of
OfficeReact.Win32with Fabric enabled.Type of Change
Why
We are building both versions of Desktop in our CI, but the
-Fabricversion is in fact a strict superset of functionality and the only one that Office uses now.What
Changed the default so that Desktop always builds with
RnwNewArch(and thereforeUseFabric) enabled. Removed the matrix configurations for DesktopFabric from all CI. Fixed the affected nuspec file. Also fixed Desktop publish to include ARM64EC for Fabric and the an issue caused by #14311.Screenshots
N/A.
Testing
Verified the build works.
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow