-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image page in RNTester hits runtime assert #4691
Comments
We had this as a bug for a while, but it looks like @jonthysell fixed it #3738? |
Seems like there were seperate issues with the image example. I wonder if resizeMode is new. |
resizeMode "repeat" has been around for both Android + iOS since 0.56. @jonthysell do you know if the RNTesterExample page was working after your change? I assumed it was still broken during 0.62 validation. |
Confirmed this reproes in 0.61-stable. |
Created card (will upgrade to issue) for missing mode: https://github.com/microsoft/react-native-windows/projects/18#card-37114262 |
This is how you show a yellowbox from native: Normally this kind of thing would go in a warnOnce which is a JS side thing. We'd probably want to only send the message once. Ideally per instance. |
sent mail to @marlenecota who added the assert. I'll track adding the yellowbox separately since it's still useful to have the ability to easily surface errors in the UI, let's keep this bug for tracking the resizeMode=repeat assert (is the assert and comment in the code still applicable?) |
The page uses Image's resizeMode = repeat which is not currently supported and asserts in Debug builds. See #2111.
Results: the app crashes (no redbox, just a hard crash)
The text was updated successfully, but these errors were encountered: