-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Image API completion #2111
Comments
Tracking progress in this is now handled in this project board: https://github.com/microsoft/react-native-windows/projects/18 |
@chrisglein what parts were you thinking needed to be documented? |
Status of implementation, vnext vs. current, issue tracking for pending implementations, justification for anything "won't fix". |
All missing APIs are tracked with issues or on the board. We have no immediate plans to create formal per-method API parity documentation, so closing this issue. |
The following unchecked properties are needed to complete the Image control integration into RNWCPP.
P1
Partially supported by Image. This guy is an Enum:
-cover: Maps to Image.Stretch.UniformToFill
-contain: Maps to Image.Stretch.Uniform
-stretch: Maps to Image.Stretch.Fill
-repeat: Not directly supported by Image. Would need to manually repeat, either by creating multiple XAML elements (eg a Grid of Images), or by dropping down to Composition (say, by using XCBB and creating a tiling Composition EffectBrush with a LoadedImageSurface as the input)
-center: Not directly supported by Image. Would need to manually center/scale to fit, either in XAML (say, by computing a Brush transform) or by dropping down to Composition (similar to repeat)
Maps to Image.ImageFailed
Not directly supported by Image, hook up to Image.ImageOpened/ImageFailed
Not directly supported by Image, hook up underlying BitmapImage.DownloadProgress
P2
Not directly supported by Image element. Would need to drop down the Composition for this. One possible proposal (using RS2 APIs):
-Create a XamlCompositionBrushBbase and use this to fill the background of a Panel (eg Canvas)
-The XCBB would create a Composition EffectBrush for the blur, and a LoadedImageSurface as the input.
A static image to display while loading the image source.
Not directly supported by Image. Would need to manually load/display this, similar to loadingIndicatorSource.
Similarly to source, this property represents the resource used to render the loading indicator for the image, displayed until image is ready to be displayed, typically after when it got downloaded from network.
Not directly supported by Image. Would need to manually load/display the loading indicator image and switch to the real image when it's ready. There is likely open-source code for this that could be borrowed.
P3
Typically Android only. When true, enables progressive jpeg streaming. See here.
Not supported by XAML. Would need to do the decoding ourselves and render ourselves.
https://facebook.github.io/react-native/docs/layout-props#overflow
Already Completed
The text was updated successfully, but these errors were encountered: