Add v8runtime export to the def file and a dummy implementation for G…

…itHub (#2472)
microsoft · May 15, 2019 · 09b2396 · 09b2396
1 parent cce30a3
commit 09b2396
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 0 deletions.
diff --git a/vnext/Desktop.DLL/react-native-win32.x64.def b/vnext/Desktop.DLL/react-native-win32.x64.def
@@ -54,6 +54,7 @@ EXPORTS
 ??1Value@jsi@facebook@@QEAA@XZ
 ??1Buffer@jsi@facebook@@UEAA@XZ
 ?makeChakraJsiRuntime@chakraruntime@jsi@facebook@@YA?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@$$QEAUChakraJsiRuntimeArgs@123@@Z
+?makeV8Runtime@v8runtime@facebook@@YA?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@XZ
 
 
 YGNodeNew

diff --git a/vnext/Desktop.DLL/react-native-win32.x86.def b/vnext/Desktop.DLL/react-native-win32.x86.def
@@ -54,6 +54,7 @@ EXPORTS
 ??1Value@jsi@facebook@@QAE@XZ
 ??1Buffer@jsi@facebook@@UAE@XZ
 ?makeChakraJsiRuntime@chakraruntime@jsi@facebook@@YG?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@$$QAUChakraJsiRuntimeArgs@123@@Z
+?makeV8Runtime@v8runtime@facebook@@YG?AV?$unique_ptr@VRuntime@jsi@facebook@@U?$default_delete@VRuntime@jsi@facebook@@@std@@@std@@XZ
 
 
 YGLog

diff --git a/vnext/ReactCommon/ReactCommon.vcxproj b/vnext/ReactCommon/ReactCommon.vcxproj
@@ -184,6 +184,7 @@
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\V8Platform.cpp"  Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' == 'true'"/>
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\V8Runtime_shared.cpp"  Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' == 'true'"/>
     <ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\V8Runtime_win.cpp"  Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' == 'true'"/>
+    <ClCompile Include="nov8.cpp" Condition="'$(Platform)' != 'arm' AND '$(USE_V8)' != 'true'"/>
     <ClCompile Include="$(YogaDir)\yoga\Utils.cpp" />
     <ClCompile Include="$(YogaDir)\yoga\YGConfig.cpp" />
     <ClCompile Include="$(YogaDir)\yoga\YGEnums.cpp" />

diff --git a/vnext/ReactCommon/nov8.cpp b/vnext/ReactCommon/nov8.cpp
@@ -0,0 +1,14 @@
+#include <memory>
+#include <jsi/jsi.h>
+
+namespace facebook {
+namespace v8runtime {
+
+// This exists just to satisfy the export requirements, so that we can share the same .def file between GitHub and the Office internal build system
+std::unique_ptr<jsi::Runtime> makeV8Runtime()
+{
+  std::abort();
+}
+
+} // namespace v8runtime
+} // namespace facebook