feat(apple): support disabling metal validation #2373
+53
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wcandillon FYI |
|
this is very cool 😎 |
tido64
reviewed
Jan 22, 2025
Saadnajmi
changed the title
|
Not obvious to me: Not every key in the app.json seems tested. Should I add some sort of test, or leave it as is? |
|
Oh, another note. Using REXML removes the newlines from the xcscheme so the structure of the file is different, but it's still usable by Xcode. Just thought I'd make sure to mention that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of repositories (react-native-webgpu, @shopfiy/react-native-skia) need to have Metal Validation turned off for their libraries to run (and be tested in CI. Let's add a way to enable/disable that from the manifest.
Note:
enableGpuValidationMode = "1"is in the xcscheme, that actually means that Metal API Validation is off. To turn it back on, you can't set it to "0", you have to remove the line. 🤷♂️Platforms affected
Test plan
Added and removed the key from the example apps' App.json, re-ran
pod installand verified that Metal API Validation would flip.