Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port --ci switch into bump-oss-version.js and remove superfluous --testing switch. #607

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

tom-un
Copy link
Collaborator

@tom-un tom-un commented Sep 21, 2020

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

The bump-oss-version.js script is used during npm publishing and during PR testing of the react-native-macos-init command line tool. Both the canary builds and the PR test use the --nightly switch which rename the package version to 0.0.0-<commithash>.

A version number of all zeros in a .podspec causes pod install to fail, so in 0.62-stable branch a --ci switch was added that changes the version to the passed in string and react-native-macos-init.yml passes in 0.62.1000 (#596). In a recent PR to master (#603), I made a similar but different fix to add a --testing flag that uses the version 1000.0.0 not realizing that this fix was already in the 0.62-stable branch.

This PR removes that script changes I made in #603 and replaces them with the fixes already made in 0.62-stable by #596.

Changelog

[macOS] [fixed] - Port --ci switch into bump-oss-version.js and remove superfluous --testing switch.

Microsoft Reviewers: Open in CodeFlow

@tom-un tom-un requested review from alloy and acoates-ms September 21, 2020 11:57
@pull-bot
Copy link

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against dfa2b09

@tom-un tom-un merged commit b83bc55 into microsoft:master Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants