Port --ci
switch into bump-oss-version.js
and remove superfluous --testing
switch.
#607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
The
bump-oss-version.js
script is used during npm publishing and during PR testing of thereact-native-macos-init
command line tool. Both the canary builds and the PR test use the--nightly
switch which rename the package version to0.0.0-<commithash>
.A version number of all zeros in a
.podspec
causespod install
to fail, so in0.62-stable
branch a--ci
switch was added that changes the version to the passed in string andreact-native-macos-init.yml
passes in0.62.1000
(#596). In a recent PR to master (#603), I made a similar but different fix to add a--testing
flag that uses the version1000.0.0
not realizing that this fix was already in the0.62-stable branch
.This PR removes that script changes I made in #603 and replaces them with the fixes already made in
0.62-stable
by #596.Changelog
[macOS] [fixed] - Port
--ci
switch intobump-oss-version.js
and remove superfluous--testing
switch.Microsoft Reviewers: Open in CodeFlow