Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accessibilityRole #2001

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Fix accessibilityRole #2001

merged 2 commits into from
Dec 20, 2023

Conversation

FalseLobster
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

In the merges for 0.73, accessibilityRole was inadvertently moved behind a #if block removing it from macOS. This restores the 0.72 behavior, but more work is coming for the new role prop. This is the main version of #1997

Test Plan:

See #1997

@FalseLobster FalseLobster requested a review from a team as a code owner December 19, 2023 22:51
@Saadnajmi
Copy link
Collaborator

/azp run

@Saadnajmi Saadnajmi merged commit fc059be into microsoft:main Dec 20, 2023
6 of 8 checks passed
@Saadnajmi Saadnajmi deleted the mainallyrole branch August 13, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FalseLobster @Saadnajmi