-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support React Native New Architecture #2792
Open
CHOIMINSEOK
wants to merge
34
commits into
microsoft:master
Choose a base branch
from
CodePushNext:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+17,247
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support react-native new architecture
@microsoft-github-policy-service agree |
Hello @CHOIMINSEOK thank you for the contribution, as you probably saw we won't support NA for RNCP but i encourage you to use it on your fork. I've also tried testing the changes and can't seem to fetch the changes from codepush server. I'll attach the logcat output for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kmsbernard and I have updated react-native-code-push to support the new architecture of React Native. We believe the best way to deploy these updates is through this main repository, and we are submitting this pull request to synchronize the following changes with the upstream master branch. Please let us know if you are open to new contributions. We are also committed to maintaining this code going forward.
Changes included in this pull request:
1. Support for the new architecture on Android and iOS
JsBundleLoader
is managed byReactHostDelegate
. Replace theJsBundleLoader
inReactHostDelegate
using reflection when new architecture is on. Most of the relevant changes can be found in this commit.2. Fix for E2E test scripts to support the new architecture