Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add terminating separator to avoid path escaping #2288

Merged
merged 11 commits into from
Jul 28, 2022
Merged

Add terminating separator to avoid path escaping #2288

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6e312e7
Set Java version 11
Jul 27, 2022
42328ef
Fix pipeline tests
Jul 26, 2022
d6bc94a
Move Java version to later stage
Jul 27, 2022
c44282a
Fix indentation
Jul 27, 2022
6f00aa5
Add terminating separator to avoid path escaping
Jun 16, 2022
468038e
Fix metro error
Jul 28, 2022
be291ff
Revert "Fix metro error"
Jul 28, 2022
6bd45e9
Revert "Fix indentation"
Jul 28, 2022
a52f7ea
Revert "Move Java version to later stage"
Jul 28, 2022
338339d
Revert "Fix pipeline tests"
Jul 28, 2022
39e53fd
Revert "Set Java version 11"
Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/app/src/main/java/com/microsoft/codepush/react/FileUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public static String readFileToString(String filePath) throws IOException {
}

private static String validateFileName(String fileName, File destinationFolder) throws IOException {
String destinationFolderCanonicalPath = destinationFolder.getCanonicalPath();
String destinationFolderCanonicalPath = destinationFolder.getCanonicalPath() + File.separator;

File file = new File(destinationFolderCanonicalPath, fileName);
String canonicalPath = file.getCanonicalPath();
Expand Down