React Native Windows >=0.63.11 Initial Implementation PR #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreidubov
approved these changes
Dec 8, 2020
Examples/CodePushDemoAppCpp/app.json
Outdated
| { | ||
| "name": "CodePushDemoAppCpp", | ||
| "displayName": "CodePushDemoAppCpp" | ||
| } |
There was a problem hiding this comment.
Could you please fix No newline at the end of file warning in all files?
There was a problem hiding this comment.
I have added newlines at the end of each file. Hopefully the warnings are fixed now.
alexandergoncharov-zz
approved these changes
Dec 8, 2020
# Conflicts: # docs/setup-windows.md
|
@andreidubov, @alexandergoncharov, the CI fails with the iOS test. I believe this change must not affect any iOS or Android behavior and the failures do no seem to be related. Is it OK to merge the PR and ignore these failures? |
sourabhdebnath
pushed a commit
to scripbox/react-native-code-push
that referenced
this pull request
May 2, 2022
) * Add React Native Windows 0.63.5+ support * modify windows/.npmignore * Update setup-windows.md * Revert package.json changes * Add newline at the end of added files * Update demo app package.json to show minimum version * Update setup-windows.md * Update setup-windows.md Co-authored-by: Aleksey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds react-native-windows >= 0.63.11 functionality to react-native-code-push.
Updated windows setup instructions and provided a demo app under
Examples/calledCodePushDemoAppCpp.Windows implementation has not been configured to work with the testing suite.
I have not checked to see whether these changes break the ios and android implementations.
The following features are missing and still need to be implemented: