Block sending requests if the deployment key is missed #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreidubov
requested review from
snowpardx,
alexandergoncharov-zz,
ruslan-bikkinin,
Krasavinigor and
n-kurdiukov-akvelon
alexandergoncharov-zz
approved these changes
Oct 30, 2020
snowpardx
approved these changes
Oct 30, 2020
ruslan-bikkinin
approved these changes
Oct 30, 2020
alexChernyatiev
approved these changes
Nov 2, 2020
sourabhdebnath
pushed a commit
to scripbox/react-native-code-push
that referenced
this pull request
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a lot of 404 errors when we try to send reportStatusDeploy from the binary version of the app. To reduce this number, we blocked sending a request when a deployment key is missed.
Related issue: #1820